Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling staging promotion pipeline run and repository #3239

Conversation

prietyc123
Copy link
Contributor

@prietyc123 prietyc123 commented Feb 8, 2024

We are facing issue quite often that the staging test get triggered even it is disabled due to bug in pac . So I have moved the file from .tekton directory

rh-pre-commit.version: 2.1.0
rh-pre-commit.check-secrets: ENABLED

@Roming22 @hugares @tisutisu

@openshift-ci openshift-ci bot requested review from amfred and rhopp February 8, 2024 13:02
@tisutisu
Copy link
Member

tisutisu commented Feb 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 8, 2024
@hugares hugares self-requested a review February 8, 2024 13:57
@openshift-ci openshift-ci bot added the approved label Feb 8, 2024
@Roming22
Copy link
Member

Roming22 commented Feb 8, 2024

@prietyc123 Please remove the resources from the repo instead of just commenting them out or moving them out of the way.

Make sure that you document the PR/changeset of your original change in the Epic/Feature so that it can easily be retrieved in the future if needed.

@hugares
Copy link
Contributor

hugares commented Feb 8, 2024

/hold

Preventing merge to allow to address @Roming22's comment

@prietyc123
Copy link
Contributor Author

@prietyc123 Please remove the resources from the repo instead of just commenting them out or moving them out of the way.

@Roming22 Are you suggesting to remove whole promotion component itself?

@prietyc123 prietyc123 force-pushed the MoveRhtapStagingPLRTOAnotherFile branch 2 times, most recently from 2eeea84 to 898b09c Compare February 12, 2024 13:57
rh-pre-commit.version: 2.1.0
rh-pre-commit.check-secrets: ENABLED
@prietyc123 prietyc123 force-pushed the MoveRhtapStagingPLRTOAnotherFile branch from 898b09c to 851951a Compare February 12, 2024 13:58
@prietyc123
Copy link
Contributor Author

@hugares @Roming22 Its ready now

@hugares
Copy link
Contributor

hugares commented Feb 12, 2024

/unhold

Copy link
Member

@Roming22 Roming22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, prietyc123, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Roming22
Copy link
Member

@prietyc123 CI failing because of the current issue with Tekton Results, you'll need to retrigger the tests once it is solved.

@prietyc123
Copy link
Contributor Author

/retest

2 similar comments
@tisutisu
Copy link
Member

/retest

@prietyc123
Copy link
Contributor Author

/retest

@tisutisu
Copy link
Member

/test appstudio-e2e-tests

Copy link

openshift-ci bot commented Feb 14, 2024

@prietyc123: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests-ocp-4-14 851951a link false /test appstudio-e2e-tests-ocp-4-14

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 361b371 into redhat-appstudio:main Feb 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants