New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling staging promotion pipeline run and repository #3239
Disabling staging promotion pipeline run and repository #3239
Conversation
/lgtm |
@prietyc123 Please remove the resources from the repo instead of just commenting them out or moving them out of the way. Make sure that you document the PR/changeset of your original change in the Epic/Feature so that it can easily be retrieved in the future if needed. |
/hold Preventing merge to allow to address @Roming22's comment |
0d26f32
to
91c1e86
Compare
@Roming22 Are you suggesting to remove whole promotion component itself? |
2eeea84
to
898b09c
Compare
rh-pre-commit.version: 2.1.0 rh-pre-commit.check-secrets: ENABLED
898b09c
to
851951a
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, prietyc123, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@prietyc123 CI failing because of the current issue with Tekton Results, you'll need to retrigger the tests once it is solved. |
/retest |
2 similar comments
/retest |
/retest |
/test appstudio-e2e-tests |
@prietyc123: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
361b371
into
redhat-appstudio:main
We are facing issue quite often that the staging test get triggered even it is disabled due to bug in pac . So I have moved the file from .tekton directory
rh-pre-commit.version: 2.1.0
rh-pre-commit.check-secrets: ENABLED
@Roming22 @hugares @tisutisu