Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pre-build and builder images #1806

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented Jun 6, 2024

I'll follow this up with another PR to use oci artifacts

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.96%. Comparing base (1376008) to head (7b6e2b3).
Report is 1 commits behind head on main.

Files Patch % Lines
...y/containerregistry/ContainerRegistryDeployer.java 57.14% 3 Missing ⚠️
...s/container/deploy/DeployPreBuildImageCommand.java 0.00% 1 Missing ⚠️
...io/jvmbuild/cli/builds/BuildDiagnosticCommand.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1806      +/-   ##
============================================
+ Coverage     44.89%   44.96%   +0.06%     
- Complexity      807      809       +2     
============================================
  Files           279      279              
  Lines         12025    12030       +5     
  Branches       1442     1442              
============================================
+ Hits           5399     5409      +10     
+ Misses         5986     5982       -4     
+ Partials        640      639       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc rnc requested a review from stuartwdouglas June 10, 2024 15:16
@rnc rnc marked this pull request as ready for review June 10, 2024 15:16
@stuartwdouglas stuartwdouglas merged commit ccfebaf into redhat-appstudio:main Jun 13, 2024
24 checks passed
@rnc rnc deleted the PREBUILDIMAGE branch June 13, 2024 07:43
@rnc rnc mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants