New profile for developer console #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kartikey-star
force-pushed
the
new_profile
branch
2 times, most recently
from
90f6769
to
a1b700d
Compare
tisutisu
reviewed
Sep 23, 2022
| @@ -291,11 +291,14 @@ A profile defines a set of checks to run and an indication of whether each check | |||
| - community | |||
| - Defines the requirements for a community chart to pass helm chart certfication. | |||
| - The ```helm-lint``` check is the only mandatory check with all other checks optional. | |||
| - developer-console | |||
There was a problem hiding this comment.
Since we are adding one more profile. Need to modify line 284 Four profiles are currently available part.
There was a problem hiding this comment.
Made the change
tisutisu
reviewed
Sep 23, 2022
Kartikey-star
force-pushed
the
new_profile
branch
from
b9fe613
to
96765e4
Compare
mmulholla
requested changes
Sep 26, 2022
docs/helm-chart-checks.md
Outdated
| @@ -291,11 +291,14 @@ A profile defines a set of checks to run and an indication of whether each check | |||
| - community | |||
| - Defines the requirements for a community chart to pass helm chart certfication. | |||
| - The ```helm-lint``` check is the only mandatory check with all other checks optional. | |||
| - developer-console | |||
| - Defines the requirements for a developer-console chart to pass helm chart certfication. | |||
| - The ```contains-test``` check is an optional check . The ```chart-testing``` and ```images-are-certified``` are checks which are not enabled for this profile. | |||
There was a problem hiding this comment.
You have also removed required-annotations-present
There was a problem hiding this comment.
Yeah i did, because we had removed all annotations from the profile yaml so it did not make sense to me, so after discussion with David removed that. Let me know if we need to revert
Kartikey-star
force-pushed
the
new_profile
branch
from
96765e4
to
388d421
Compare
mmulholla
requested changes
Sep 27, 2022
docs/helm-chart-checks.md
Outdated
| @@ -291,11 +291,14 @@ A profile defines a set of checks to run and an indication of whether each check | |||
| - community | |||
| - Defines the requirements for a community chart to pass helm chart certfication. | |||
| - The ```helm-lint``` check is the only mandatory check with all other checks optional. | |||
| - developer-console | |||
| - Defines the requirements for a developer-console chart to pass helm chart certfication. | |||
There was a problem hiding this comment.
It is not about passing helm chart certification. Maybe "to validate a chart."
Signed-off-by: Kartikey Mamgain <mamgainkartikey@gmail.com>
Kartikey-star
force-pushed
the
new_profile
branch
from
388d421
to
be6e15c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new profile to be used for ODC integration.
JIRA:https://issues.redhat.com/browse/HELM-412