Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG OCPBUGS-5377: Fix channel staying in close state #180

Merged
merged 1 commit into from Jan 4, 2023

Conversation

aneeshkp
Copy link
Member

@aneeshkp aneeshkp commented Jan 4, 2023

close channel , once closed stays in closed state and causing holdover time to cancel immediately without changing state to FREERUN
Signed-off-by: Aneesh Puttur aneeshputtur@gmail.com

Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
@openshift-ci openshift-ci bot added the approved label Jan 4, 2023
@aneeshkp aneeshkp changed the title Fix channel staying in close state BUG OCPBUGS-5377: Fix channel staying in close state Jan 4, 2023
@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-5377, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

close channel , once closed stays in closed state and causing holdover time to cancel immediately without changing state to FREERUN
Signed-off-by: Aneesh Puttur aneeshputtur@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Member Author

aneeshkp commented Jan 4, 2023

/jira refresh

@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-5377, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Member Author

aneeshkp commented Jan 4, 2023

/cherrypick release-4.12

@openshift-cherrypick-robot

@aneeshkp: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Member Author

aneeshkp commented Jan 4, 2023

/jira refresh

@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-5377, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@josephdrichard josephdrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2023

@josephdrichard: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, josephdrichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aneeshkp aneeshkp merged commit ef0ac92 into redhat-cne:main Jan 4, 2023
@openshift-ci-robot
Copy link

@aneeshkp: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5377 has been moved to the MODIFIED state.

In response to this:

close channel , once closed stays in closed state and causing holdover time to cancel immediately without changing state to FREERUN
Signed-off-by: Aneesh Puttur aneeshputtur@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@aneeshkp: new pull request created: #181

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants