BUG OCPBUGS-6050: Amq connection configurable timeout and nohup #187
Conversation
jzding
changed the title
cmd/main.go
Outdated
| @@ -71,6 +73,7 @@ func main() { | |||
| flag.StringVar(&transportHost, "transport-host", "amqp:localhost:5672", "The transport bus hostname or service name.") | |||
| flag.IntVar(&apiPort, "api-port", 8089, "The address the rest api endpoint binds to.") | |||
| flag.StringVar(&httpEventPublisher, "http-event-publishers", "", "Comma separated address of the publishers available.") | |||
| flag.StringVar(&amqInitTimeout, "amq-init-timeout", amqInitTimeoutDefault.String(), "The retry duration for establishing an amq connection.") | |||
There was a problem hiding this comment.
this should transport protocol agnostic . You can't have amq specific flags on sidecar
There was a problem hiding this comment.
AMQ is going to go away and it not configurable for PTP operator
There was a problem hiding this comment.
removed the command line argument
jzding
changed the title
jzding
changed the title
jzding
force-pushed
the
amq-race
branch
3 times, most recently
from
b1a98d3
to
f7d0c37
Compare
jzding
changed the title
jzding
force-pushed
the
amq-race
branch
3 times, most recently
from
2c1fdce
to
5a7591c
Compare
Allow configurable timeout for initial amq connection. Introduce amqp://nohup transportHost for local logging of events when amq connection is not available Signed-off-by: Jack Ding <jackding@gmail.com>
jzding
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, jzding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jzding
changed the title
|
@jzding: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-6050 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Allow configurable timeout for initial amq connection.
Introduce amqp://nohup transportHost for local logging of events when amq connection is not available
Signed-off-by: Jack Ding jackding@gmail.com