Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-25411: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs #276

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #270

/assign aneeshkp

Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-24595 has been cloned as Jira Issue OCPBUGS-25411. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-25411: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs

In response to this:

This is an automated cherry-pick of #270

/assign aneeshkp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign aneeshkp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-24595: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs [release-4.15] OCPBUGS-25411: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs Dec 14, 2023
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a redhat-cne member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25411, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #270

/assign aneeshkp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 14, 2023
@aneeshkp
Copy link
Member

/approved

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 9b21206 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jzding
Copy link
Member

jzding commented Dec 14, 2023

/jira refresh

@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-25411, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24595 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-24595 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only redhat-cne members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jzding: This pull request references Jira Issue OCPBUGS-25411, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24595 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-24595 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jzding jzding merged commit 61cb72b into redhat-cne:release-4.15 Dec 14, 2023
4 of 6 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-25411: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25411 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #270

/assign aneeshkp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cloud-event-proxy-container-v4.15.0-202312141928.p0.g61cb72b.assembly.stream for distgit cloud-event-proxy.
All builds following this will include this PR.

jzding pushed a commit to jzding/cloud-event-proxy that referenced this pull request Jan 8, 2024
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
Co-authored-by: Aneesh Puttur <aputtur@redhat.com>
jzding added a commit that referenced this pull request Jan 18, 2024
* Process ts2phc and dpll events for multi-cards

Signed-off-by: Jack Ding <jackding@gmail.com>

* Improve coverage on metrics unit tests

Added events verification
Added more tests

Signed-off-by: Jack Ding <jackding@gmail.com>

* fix multipleproces and nmea metrics (#276)

Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
Co-authored-by: Aneesh Puttur <aputtur@redhat.com>

* add gnss state for getcurrent state call (#280)

Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
Co-authored-by: Aneesh Puttur <aputtur@redhat.com>

* fix removing of metrics on delete of ptpconfig (#282)

* Fix nul pointer when reading nmeastring

Signed-off-by: Aneesh Puttur <aputtur@redhat.com>

---------

Signed-off-by: Jack Ding <jackding@gmail.com>
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
Co-authored-by: OpenShift Cherrypick Robot <openshift-cherrypick-robot@redhat.com>
Co-authored-by: Aneesh Puttur <aputtur@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants