-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move aro bastion #6442
Merged
Merged
Move aro bastion #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkulhanek
approved these changes
May 14, 2023
hhpatel14
pushed a commit
to hhpatel14/agnosticd
that referenced
this pull request
May 17, 2023
* move aro install to bastion add specific role definition for vnet * fix variables * update azure open env * fix some waits * fix bug * change retries * add sub * add debug * fix debug * update identifier uri * remove identifier uri from provision * fix destroy * fix aro install * add login back * fix var * fix bad auth source * update attribute * fix pull secret * add parkinglot scope * fix role * remove unneccessary check * add missing required attribute * try again * fix bookbag deploy and destroy * fix broken argument * move bookbag to end * fix default var * fix destroy * remove satellite from deletion * fix cloud provider * add kubeconfig to user homedir * fix typo * fix typo * fix kubeconfig * fix var * install oc first * debug on delete * test apps * debugg * debug * try to fix delete * fix loop * fix delete * stupid microsoft * really stupid microsoft --------- Co-authored-by: rut31337 <rut31337@gmail.com> Co-authored-by: rut31337 <opentlc-mgr@admin-dev.na.shared.opentlc.com>
hhpatel14
pushed a commit
to migtools/agnosticd
that referenced
this pull request
May 17, 2023
* move aro install to bastion add specific role definition for vnet * fix variables * update azure open env * fix some waits * fix bug * change retries * add sub * add debug * fix debug * update identifier uri * remove identifier uri from provision * fix destroy * fix aro install * add login back * fix var * fix bad auth source * update attribute * fix pull secret * add parkinglot scope * fix role * remove unneccessary check * add missing required attribute * try again * fix bookbag deploy and destroy * fix broken argument * move bookbag to end * fix default var * fix destroy * remove satellite from deletion * fix cloud provider * add kubeconfig to user homedir * fix typo * fix typo * fix kubeconfig * fix var * install oc first * debug on delete * test apps * debugg * debug * try to fix delete * fix loop * fix delete * stupid microsoft * really stupid microsoft --------- Co-authored-by: rut31337 <rut31337@gmail.com> Co-authored-by: rut31337 <opentlc-mgr@admin-dev.na.shared.opentlc.com>
When I try to run anything on the line in the set repositories from this commit, it fails with the following message:
Reverting to commit c72b7f1 and I no longer receive this error (which is prior to the change listed). Also, I'm running this with Ansible-navigator - perhaps that might explain the error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
major updates to open-environment-azure to install az and oc as well as fix some issues with satellite registration.
allow version setting in aro. removed duplications in azure cloud provider. fixed bookbag to be in the right place. no need to destroy bookbag as its part of the aro cluster.
ISSUE TYPE
COMPONENT NAME
open-environment-azure
ADDITIONAL INFORMATION