Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aro bastion #6442

Merged
merged 45 commits into from
May 15, 2023
Merged

Move aro bastion #6442

merged 45 commits into from
May 15, 2023

Conversation

rut31337
Copy link
Collaborator

SUMMARY

major updates to open-environment-azure to install az and oc as well as fix some issues with satellite registration.
allow version setting in aro. removed duplications in azure cloud provider. fixed bookbag to be in the right place. no need to destroy bookbag as its part of the aro cluster.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

open-environment-azure

ADDITIONAL INFORMATION

@rut31337 rut31337 requested a review from a team as a code owner May 12, 2023 22:26
@wkulhanek wkulhanek merged commit 8c2cf12 into development May 15, 2023
3 checks passed
@wkulhanek wkulhanek deleted the move_aro_bastion branch May 15, 2023 07:57
hhpatel14 pushed a commit to hhpatel14/agnosticd that referenced this pull request May 17, 2023
* move aro install to bastion add specific role definition for vnet

* fix variables

* update azure open env

* fix some waits

* fix bug

* change retries

* add sub

* add debug

* fix debug

* update identifier uri

* remove identifier uri from provision

* fix destroy

* fix aro install

* add login back

* fix var

* fix bad auth source

* update attribute

* fix pull secret

* add parkinglot scope

* fix role

* remove unneccessary check

* add missing required attribute

* try again

* fix bookbag deploy and destroy

* fix broken argument

* move bookbag to end

* fix default var

* fix destroy

* remove satellite from deletion

* fix cloud provider

* add kubeconfig to user homedir

* fix typo

* fix typo

* fix kubeconfig

* fix var

* install oc first

* debug on delete

* test apps

* debugg

* debug

* try to fix delete

* fix loop

* fix delete

* stupid microsoft

* really stupid microsoft

---------

Co-authored-by: rut31337 <rut31337@gmail.com>
Co-authored-by: rut31337 <opentlc-mgr@admin-dev.na.shared.opentlc.com>
hhpatel14 pushed a commit to migtools/agnosticd that referenced this pull request May 17, 2023
* move aro install to bastion add specific role definition for vnet

* fix variables

* update azure open env

* fix some waits

* fix bug

* change retries

* add sub

* add debug

* fix debug

* update identifier uri

* remove identifier uri from provision

* fix destroy

* fix aro install

* add login back

* fix var

* fix bad auth source

* update attribute

* fix pull secret

* add parkinglot scope

* fix role

* remove unneccessary check

* add missing required attribute

* try again

* fix bookbag deploy and destroy

* fix broken argument

* move bookbag to end

* fix default var

* fix destroy

* remove satellite from deletion

* fix cloud provider

* add kubeconfig to user homedir

* fix typo

* fix typo

* fix kubeconfig

* fix var

* install oc first

* debug on delete

* test apps

* debugg

* debug

* try to fix delete

* fix loop

* fix delete

* stupid microsoft

* really stupid microsoft

---------

Co-authored-by: rut31337 <rut31337@gmail.com>
Co-authored-by: rut31337 <opentlc-mgr@admin-dev.na.shared.opentlc.com>
@9strands
Copy link
Collaborator

9strands commented May 18, 2023

@rut31337

https://github.com/redhat-cop/agnosticd/blame/c72b7f18347a3f36590785e3f8904a912fd29ff5/ansible/roles/set-repositories/tasks/main.yml#L10

When I try to run anything on the line in the set repositories from this commit, it fails with the following message:

TASK [set-repositories : Configure satellite repositories] *********************
fatal: [cluster.domain.local]: FAILED! => {"msg": "The conditional check '(ACTION == \"create\" or ACTION == \"provision\")' failed. The error was: error while evaluating conditional ((ACTION == \"create\" or ACTION == \"provision\")): 'ACTION' is undefined. 'ACTION' is undefined\n\nThe error appears to be in '/home/jappleii/development/agnosticd/ansible/roles/set-repositories/tasks/main.yml': line 9, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- when:\n  ^ here\n"}

Reverting to commit c72b7f1 and I no longer receive this error (which is prior to the change listed).

Also, I'm running this with Ansible-navigator - perhaps that might explain the error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants