Use ConfigMaps CreationDate for JKS CreateDate property #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will now build the image and test it on our internal cluster. |
|
@raffaelespazzoli I can confirm, that with this patch applied, the ConfigMap truststore.jks is no more updated on every restart of the cert-utils-operator pods. |
|
can you rebase? |
This requires the keystore-go to be updated to v4 and this requires at least go 1.17. So i've updated to go 1.20 too. I've added a new test case to check the equality of the JKS after two reconciles. The issues only started to exist, when then ca-bundle.crt contained many certs. So i've included the Mozilla CA list as testdata. Once I remove `keystore.WithOrderedAliases()`, the test fails. Fixes #142
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the keystore-go to be updated to v4 and this requires at least go 1.17. So i've updated to go 1.20 too.
I've added a new test case to check the equality of the JKS after two reconciles. The issues only started to exist, when then ca-bundle.crt contained many certs. So i've included the Mozilla CA list as testdata. Once I remove
keystore.WithOrderedAliases(), the test fails.Fixes #142