Add ability to prune custom resources #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkupferer
approved these changes
May 29, 2020
sabre1041
reviewed
May 30, 2020
There was a problem hiding this comment.
@etsauer There is a race condition on the new UserConfig resource.
error: unable to recognize "simple-bootstrap/3-operator-configs/sandbox-userconfig.yaml": no matches for kind "UserConfig" in version "redhatcop.redhat.io/v1alpha1"
The output of the command should also provide an output of the newly added UserConfig resource that should be applied ton the cluster in the README
|
@sabre1041 since we've opened #14, can we go ahead and merge this, knowing that you might have to run apply a couple times to make it fully work? |
jkupferer
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.