Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fix to job label #20

Merged
merged 2 commits into from
Jun 13, 2020
Merged

small fix to job label #20

merged 2 commits into from
Jun 13, 2020

Conversation

etsauer
Copy link
Contributor

@etsauer etsauer commented Jun 13, 2020 •
edited
Loading

Missed updating the label in the job config.

@redhat-cop/declarative-openshift

sabre1041
sabre1041 requested changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etsauer Can you also update the two other references that still contain example.com/project

  1. In the base README
  2. In the argocd-bootstrap README?

sabre1041
sabre1041 approved these changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit 1e73600 into redhat-cop:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabre1041 sabre1041 sabre1041 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etsauer @sabre1041