-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit argocd-bootstrap #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few requested changes. However, a similar pattern has emerged with both PR's thus far in this repository:
Registering an operator using the OLM is an asynchronous process and in many cases results in an error when attempting to apply a Subscription
and an associated custom resource. One such solution is to separate the OLM components and the custom resource creation. A verification can occur to ensure the CRD was applied successfully using the following example:
until oc wait --for condition=established --timeout=60s crd/argocds.argoproj.io; do sleep 2; done
example: basic | ||
example.com/component: operators | ||
example.com/project: argocd-bootstrap | ||
name: example-argocd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace
field should be specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in latest comit
@sabre1041 I'd like to separate the handling of the operator race condition as a separate issue. #14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabre1041 @etsauer I have updated the argocd configs to address the comments. This should be good to merge
example: basic | ||
example.com/component: operators | ||
example.com/project: argocd-bootstrap | ||
name: example-argocd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in latest comit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a directory that contains a set of manifests to install the argocd-operator and argocd, with accompanying README. I would love to add a sample app to be managed by argocd in future work