Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit argocd-bootstrap #3

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

gnekic
Copy link

@gnekic gnekic commented May 31, 2020

Add a directory that contains a set of manifests to install the argocd-operator and argocd, with accompanying README. I would love to add a sample app to be managed by argocd in future work

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few requested changes. However, a similar pattern has emerged with both PR's thus far in this repository:

Registering an operator using the OLM is an asynchronous process and in many cases results in an error when attempting to apply a Subscription and an associated custom resource. One such solution is to separate the OLM components and the custom resource creation. A verification can occur to ensure the CRD was applied successfully using the following example:

until oc wait --for condition=established --timeout=60s crd/argocds.argoproj.io; do sleep 2; done

example: basic
example.com/component: operators
example.com/project: argocd-bootstrap
name: example-argocd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace field should be specified

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in latest comit

argocd-bootstrap/3-argocd/argocd-basic.yaml Outdated Show resolved Hide resolved
@etsauer
Copy link
Contributor

etsauer commented Jun 5, 2020

@sabre1041 I'd like to separate the handling of the operator race condition as a separate issue. #14

Copy link
Author

@gnekic gnekic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabre1041 @etsauer I have updated the argocd configs to address the comments. This should be good to merge

example: basic
example.com/component: operators
example.com/project: argocd-bootstrap
name: example-argocd
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in latest comit

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etsauer etsauer merged commit 52d4b4b into redhat-cop:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants