Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gpu Refactor #298

Merged
merged 6 commits into from
May 2, 2024
Merged

Gpu Refactor #298

merged 6 commits into from
May 2, 2024

Conversation

strangiato
Copy link
Contributor

This update is intended to improve the maintainability of the NVIDIA GPU config.

These changes were in collaboration with @codekow in a separate repo that we are bringing back over to the GitOps catalog.

adetalhouet
adetalhouet approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@adetalhouet adetalhouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been better to extract the changes to scripts/validate_manifests.sh. I don't think it is a big deal given the change though, but a good practice.

@adetalhouet adetalhouet merged commit 0d9c167 into redhat-cop:main May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adetalhouet adetalhouet adetalhouet approved these changes

@gnunn1 gnunn1 Awaiting requested review from gnunn1 gnunn1 is a code owner

@pittar pittar Awaiting requested review from pittar pittar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strangiato @adetalhouet