Add support for more than 20 Okta groups #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klofton-bw
force-pushed
the
master
branch
3 times, most recently
from
ed14b19
to
f23e25c
Compare
|
Code looks good to my eyeballs, @klofton-bw promises me that the new addition the CRD is optional, and if not set, the default is 1000 groups. Nice work |
Jmainguy
approved these changes
Jul 22, 2021
slmingol
approved these changes
Jul 23, 2021
sabre1041
reviewed
Aug 6, 2021
README.md
Outdated
| @@ -442,6 +391,58 @@ Additional metadata based on Keycloak group are also added to the OpenShift grou | |||
| * Parent/child relationship between groups and their subgroups | |||
| * Group attributes | |||
|
|
|||
| ### Keycloak | |||
There was a problem hiding this comment.
Can this be moved above Okta to retain alphabetic order
There was a problem hiding this comment.
Yeah, removed commit where I moved it
slmingol
approved these changes
Aug 11, 2021
sabre1041
requested changes
Aug 12, 2021
api/v1alpha1/groupsync_types.go
Outdated
| @@ -360,6 +360,10 @@ type OktaProvider struct { | |||
| // +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Profile Key",xDescriptors={"urn:alm:descriptor:com.tectonic.ui:text"} | |||
| // +kubebuilder:validation:Optional | |||
| ProfileKey string `json:"profileKey"` | |||
| // GroupLimit is the maximum number of groups that can be synced. Default is "1000" | |||
| // +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Group Limit",xDescriptors={"urn:alm:descriptor:com.tectonic.ui:text"} | |||
There was a problem hiding this comment.
Since this is an integer, can we use urn:alm:descriptor:com.tectonic.ui:number since it is an integer?
slmingol
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the Okta syncer due to the way the API call was made and how the client returned the groups in pages. This fix makes the number of groups the syncer can pull customizable with a default of 1000. Fixes issue #105