Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop username&password option #114

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Drop username&password option #114

merged 3 commits into from
Aug 23, 2021

Conversation

davidkarlsen
Copy link
Contributor

@davidkarlsen davidkarlsen commented Aug 7, 2021 •
edited

Fixes #113

@davidkarlsen
Drop username&password option
51ddb08
@davidkarlsen
Update docs
c111071 
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
@davidkarlsen davidkarlsen marked this pull request as ready for review August 12, 2021 07:10
@davidkarlsen
Copy link
Contributor Author

@sabre1041 WDYT?

@davidkarlsen
Copy link
Contributor Author

@raffaelespazzoli ptal?

@davidkarlsen
Leave constants alone
26cd66e 
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
sabre1041
sabre1041 approved these changes Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041
Copy link
Collaborator

@davidkarlsen Thanks for this. Good timing too

https://thenewstack.io/github-kisses-passwords-goodbye/

@sabre1041 sabre1041 merged commit 86dd970 into redhat-cop:master Aug 23, 2021
@davidkarlsen davidkarlsen deleted the issue113 branch August 23, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabre1041 sabre1041 sabre1041 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github: drop username/password option
2 participants
@davidkarlsen @sabre1041