operators-installer - add default labels to all resources as well as new parameter 'commonLabels' which allows user to specify addtional labels #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itewk
force-pushed
the
feature/operators-installer-labels
branch
from
0388635
to
a12f4a6
Compare
|
@eformat can i get a quick turn around on this one? IHAC i want to use this update with tomorrow. |
…new parameter 'commonLabels' which allows user to specify addtional labels
itewk
force-pushed
the
feature/operators-installer-labels
branch
from
a12f4a6
to
125786c
Compare
|
LGTM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR About?
operators-installer
commonLabelsparameter to allow user specified labelsHow do we test this?
helm template foo ./charts/operators-installer -f charts/operators-installer/test-install-old-operator-values.yaml --namespace=ian-test --create-namespace | lesstest-label: xyz123on all resourcescc: @redhat-cop/day-in-the-life