Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators-installer: incremental upgrades #532

Merged

Conversation

itewk
Copy link
Contributor

@itewk itewk commented Jun 11, 2024

What is this PR About?

  • update to oc v4.15 tools
  • refactor manual approver jobs to use python rather then bash for better maintainability and future features
  • add option that when manual mode is being used to automatically approve and verify install of every CSV between current CSV and desired CSV
  • enable / fix tests that were not being run because they needed to end with *-values.yaml

How do we test this?

tests updated to test all new functionality

cc: @redhat-cop/day-in-the-life

@itewk itewk force-pushed the feature/operators-installer-incremental-upgrades branch 4 times, most recently from c2ac84a to cdb17f5 Compare June 11, 2024 21:42
@itewk itewk force-pushed the feature/operators-installer-incremental-upgrades branch 5 times, most recently from df88b9e to 9d35d67 Compare June 13, 2024 13:55
@itewk itewk changed the title WIP: operators-installer: incremental upgrades DRAFT: operators-installer: incremental upgrades Jun 13, 2024
@itewk itewk force-pushed the feature/operators-installer-incremental-upgrades branch 19 times, most recently from f63705d to e1c5d0f Compare June 14, 2024 17:55
@itewk itewk force-pushed the feature/operators-installer-incremental-upgrades branch 3 times, most recently from 20a7dbf to 8c0f158 Compare June 14, 2024 18:31
@itewk itewk marked this pull request as ready for review June 14, 2024 18:39
@itewk itewk requested a review from jtudelag June 14, 2024 18:39
@itewk
Copy link
Contributor Author

itewk commented Jun 14, 2024

@jtudelag all ready for review now.

@itewk itewk changed the title DRAFT: operators-installer: incremental upgrades operators-installer: incremental upgrades Jun 15, 2024
@itewk
Copy link
Contributor Author

itewk commented Jun 15, 2024

@jtudelag all ready for review now.

Ugggg. I see I didn't fix my got commit comment. I'll do that next week

@itewk itewk force-pushed the feature/operators-installer-incremental-upgrades branch from 8c0f158 to 2979876 Compare June 17, 2024 11:35
this is a pre-work to enahnacing to be able to deal with incremental
upgrades
* adds `automaticIntermediateManualUpgrades` option to allow the
approver to automatically approve ever required update between currently
installed CSV and target CSV
@itewk itewk force-pushed the feature/operators-installer-incremental-upgrades branch from 2979876 to 9df70a9 Compare June 17, 2024 11:36
@itewk
Copy link
Contributor Author

itewk commented Jun 18, 2024

@redhat-cop/day-in-the-life now that this is ready can i get a peer review and merge?

@ckavili
Copy link
Contributor

ckavili commented Jun 19, 2024

wow that's a very big chart with very comprehensive tests now! :) thanks @itewk 🚀

@ckavili ckavili merged commit 2604e2c into redhat-cop:main Jun 19, 2024
4 checks passed
@itewk itewk deleted the feature/operators-installer-incremental-upgrades branch June 20, 2024 12:30
@itewk
Copy link
Contributor Author

itewk commented Jun 20, 2024

wow that's a very big chart with very comprehensive tests now! :) thanks @itewk 🚀

thank you. i started my life as a developer writing 1000s of tests for the eclipse project. i find perverse satisfaction in it.

also this chart is used in production at multiple clients. got to be robust. until we get OLM 2.0 and hopefully this all becomes redundent/uncessary. but who knows when that will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants