Make sonar plugin installer more idempotent #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oybed
reviewed
Apr 16, 2019
oybed
reviewed
Apr 16, 2019
oybed
reviewed
Apr 18, 2019
| command: "oc rollout latest --namespace={{ namespace }} {{ pod_prefix }}" |
There was a problem hiding this comment.
We have seen this failing at random times. A few suggestions:
- Before starting the steps above, wait for the current deployment to be "stable" to ensure successful install of plugins
- Only do another "rollout" if the plugin was successfully installed above
- Consider using a different approach than "rollout" since you're not really changing the image - i.e.: scale-down/scale-up, check for successful scale down/up, etc. to avoid a failed "rollout"
|
Per chat convo - closing as moving in different direction going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #360
How should this be tested?
See the README in the
add-sonar-pluginroleIs there a relevant Issue open for this?
#360
Other Relevant info, PRs, etc.
M/A
People to notify
cc: @redhat-cop/infra-ansible @oybed @tylerauerbeck