-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update playbook example and other potential enhancements #108
Comments
|
cool, will get a PR up in a couple days for 1 and open an issue for 2 |
@ingmarfjolla, does merged PR #109 solve number 1? Anything else needed to close this issue? |
@swapdisk sorry I missed this, yes I think we can close this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, we just used this collection to automate an upgrade and were wondering what enhancements might work / what might not be needed for the repo. @pavuluriharsha @elaczyns
I see that a PR with updated documentation has been merged, so would it be worthwhile to add example playbooks for the analysis and upgrade that make use of the variables? As an example in the upgrade playbook:
we needed to make use of the variables and having an example in the repo for others would be handy to see an example.
One of the issues we ran into was here: https://access.redhat.com/solutions/5057391 and we tested and verified the upstream RPM worked without needing to add any extra space and this collection was able to default to using that. Is that something this repo should mention as a possible workaround? If so, there could be an extra role added (we just added a task) that might take care of installing that on the target machines with the caveat that it's currently unsupported.
We added our own assertion at the end of the analysis task that would fail in the case of any inhibitors so that we wouldn't move forward with the upgrade. This one is more of a question, but for my own understanding is there a reason the analysis task doesn't currently aim to fail if there are any inhibitors?
The text was updated successfully, but these errors were encountered: