Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checking before resizing volumes #2

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

ygalblum
Copy link
Collaborator

Adjust the check script to also support resize checks Add tasks for check resize and use them according to the command Add test playbook
Add change log

Adjust the check script to also support resize checks
Add tasks for check resize and use them according to the command
Add test playbook
Add change log

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
Copy link
Member

@swapdisk swapdisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried testing space check action just now on a RHEL7 instance and it failed for me. The problem appears to be executable: python3 with the script tasks. There is no python3 on RHEL7 hosts.

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
@ygalblum
Copy link
Collaborator Author

I've changed it to get the executable from the ansible facts. Should work for all installations now

ygalblum and others added 2 commits July 24, 2023 17:58
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
@swapdisk
Copy link
Member

LGTM...

@swapdisk swapdisk merged commit e3e98c9 into redhat-cop:main Jul 24, 2023
7 checks passed
@ygalblum ygalblum deleted the add_check_for_resize branch July 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants