Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell GitHub actions workflow #45

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

swapdisk
Copy link
Member

@swapdisk swapdisk commented Jan 4, 2024

  • Use codespell for spell checking code in PRs and pushes to main.
  • Fix existing typos to make codespell happy.

@swapdisk swapdisk requested a review from ygalblum January 4, 2024 21:20
Copy link
Collaborator

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the change.
Should we also add it to the release flow: https://github.com/redhat-cop/infra.lvm_snapshots/blob/main/.github/workflows/release.yml#L9?

@swapdisk
Copy link
Member Author

swapdisk commented Jan 8, 2024

Should we also add it to the release flow?

Duh! I've now made it consistent with the others and added to the release workflow. Let me know if that looks good.

@ygalblum ygalblum merged commit f6dc03b into redhat-cop:main Jan 9, 2024
9 checks passed
@swapdisk swapdisk deleted the add_codespell branch January 9, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants