Fix maths #60
Merged
Fix maths #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygalblum
reviewed
Feb 28, 2024
add spaces for style filesystem is a word don't touch logical volumes support ext[234] round down requested size, use sectors with sfdisk, fix bad math prevent globbing and word splitting changelog quit if shrink size is zero PV extents numbered starting at 0 oops, go the other way! move left, not right! get pedantic about bigboot_size calculate new pv size based on partition size lsblk output pipe tail not reliable
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues raised under #58 and generally cleaned up and simplified the
bigboot.shscript. No changes required to existing playbooks. Working as expected in my initial testing, but I will keep banging on it, so opening the PR as draft for now.