Installplan Job template update #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethahealy
approved these changes
Feb 23, 2022
|
/lgtm |
oybed
reviewed
Feb 23, 2022
There was a problem hiding this comment.
Looks like this took a bit of a different approach than discussed as we should just add the "wait" and otherwise keep it the same IMHO. Since the PR was merged before we managed to review, let's submit some follow-up PRs and fine-tune.
Also some inline comment
| echo "Found ${installplan}.." | ||
| if [ $(oc get installplan $installplan -o jsonpath="{.spec.approved}") = "false" ]; then | ||
| oc patch installplan $installplan -n ${NAMESPACE} --type=json -p='[{"op":"replace","path": "/spec/approved", "value": true}]' | ||
| echo "${installplan} approved, job completed succesfully. Your operator should now be in the process of installation" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR About?
Installplan Job template update adds a new functionality on top of the legacy behavior. New approach triggers the approver job to check for installplan on a periodic basis, instead of legacy behavior of trying to approve installplan once and quitting.
Legacy behavior is still in place, and is used by default. New behavior is enabled by setting up
WAIT_FOR_INSTALLPLANtotruewhen applying the template. In the new approach, job will run for maximum of 3600 seconds, it's going to exit once installplan for specified namespace is approved .How do we test this?
Create a job based on the new template with
WAIT_FOR_INSTALLPLANset totrue, create an operator subscription (approval mode: Manual), and observe how the installplan gets approvedcc: @redhat-cop/day-in-the-life