Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor main committime method to reduce complexity #98

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Refactor main committime method to reduce complexity #98

merged 1 commit into from
Jun 18, 2020

Conversation

etsauer
Copy link
Collaborator

@etsauer etsauer commented Jun 17, 2020

This should resolve the final linting error as well.

@redhat-cop/mdt

@etsauer
Copy link
Collaborator Author

etsauer commented Jun 17, 2020

To test:

  1. Log in to openshift (with build data present)
  2. Start exporter. python exporters/committime/app.py
  3. Once started, run the following and confirm you get results back: curl localhost:8080 | grep -e 'commit_timestamp{.*} [0-9]\.[0-9]\{1,\}e+[0-9]\{2\}'

Copy link
Collaborator

@themoosman themoosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themoosman themoosman merged commit ea933fe into dora-metrics:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants