Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded components posing as not downloaded #909

Closed
jrichter1 opened this issue Oct 11, 2017 · 13 comments
Closed

Downloaded components posing as not downloaded #909

jrichter1 opened this issue Oct 11, 2017 · 13 comments
Assignees
Labels
Milestone

Comments

@jrichter1
Copy link
Collaborator

Some components never seem to act like they have been downloaded. The file sizes might be wrong.

@jrichter1 jrichter1 added this to the 2.1.0-GA milestone Oct 11, 2017
@jrichter1 jrichter1 self-assigned this Oct 11, 2017
@jrichter1
Copy link
Collaborator Author

The sizes don't match, I'm going to keep this open as a reminder for when we update to the release candidates.

@jrichter1
Copy link
Collaborator Author

And strangely enough, it looks like some files actually return different sizes on different systems.

@mohitsuman
Copy link
Collaborator

@jrichter1 Which components are these, I will check them individually for the file size.

@jrichter1
Copy link
Collaborator Author

@mohitsuman from what I've experienced, it was: devstudio, CDK (mac only), kompose and fuse platform (EAP one)
The really weird thing though, fs.stat returns different size for devstudio for each OS I've tried, even though it is the same file

@dgolovin dgolovin added this to Planned in devex #139 October 2017 Oct 11, 2017
@dgolovin
Copy link
Contributor

dgolovin commented Oct 12, 2017

could that be related to node.js version we use to build in Central CI?
@jrichter1 @mohitsuman I installed version 8 on my mac mini and it works as expected.

@jrichter1
Copy link
Collaborator Author

@dgolovin all fs.stat does is call the appropriate stat function from the terminal and put the results into an object
And from what I have seen, different OSes (or indeed different file systems) just return slightly different values.

For example, what stat returns for devstudio:

  • mac 11.15.4: 677694419
  • win10: 677689480

@dgolovin dgolovin self-assigned this Oct 13, 2017
@dgolovin
Copy link
Contributor

Problem is mkdirp.sync(this.downloadFolder); call inside InstallableItem constructor. It has different behavior between mac and windows. On windows if targeted folder exists execution continues, on mac it throws exception. It means everything is fine for first execution when no cache folder and it starts to behave wrong for all consecutive times.

dgolovin added a commit to dgolovin/developer-platform-install that referenced this issue Oct 13, 2017
…downloaded

Check if download cache file doe not exist before
creating it to avoid problems on macOS.
@jrichter1 jrichter1 moved this from Planned to Done in devex #139 October 2017 Oct 16, 2017
@jrichter1
Copy link
Collaborator Author

Fuse on EAP still has a different size to what is in requirements.json for me. Anyone care to verify?

@dgolovin
Copy link
Contributor

I'll check it, it is probably related to fact that Fuse on EAP is downloading two files under the hood, not one.

@mohitsuman
Copy link
Collaborator

mohitsuman commented Oct 30, 2017

On macOS, these are the 2 files which are getting downloaded & installed.
_fuse-eap-installer-6.3.0.redhat-187.jar : 234.9 MB
jboss-eap-6.4.0.GA-installer.jar : 201.3 MB

On the UI selection page, it shows 217.49 MB.

@dgolovin
Copy link
Contributor

@mohitsuman Problem is even it is downloaded it is still marked as Selected for download, could you confirm that?

@mohitsuman
Copy link
Collaborator

@dgolovin Yeah it is marked as Selected for download.

@dgolovin
Copy link
Contributor

dgolovin commented Nov 7, 2017

I've opened issue specific to components that require more than one resource to download #995

@dgolovin dgolovin moved this from Done to Verified in devex #139 October 2017 Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

3 participants