gulp task package refactored, small fixes in other tasks #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ppitonak
commented
Apr 20, 2016
ppitonak
commented
- the most important Gulp task is split into multiple tasks so it is easier to understand and debug/improve
- return and callbacks added where necessary for tasks to run correctly
- known issue: Gulp doesn't log tasks ideally
|
@dgolovin, @jrichter1 please review and merge if everything is OK. |
|
The 'dist' script creates a simple installer and then overwrites it with a bundled installer - both files have the same name. |
| @@ -38,6 +39,9 @@ let zaSfxExe = path.join(zaRoot, '7zS.exe'); | |||
| let zaExtra7z = path.join(zaRoot, '7z920_extra.7z'); | |||
| let rhZip = path.join(zaRoot, 'resource_hacker.zip'); | |||
| let rhExe = path.join(zaRoot, 'ResourceHacker.exe'); | |||
| let zaElectronPackage = path.join(zaRoot, artifactName + '-win32-x64'); | |||
| let bundled7z = path.join(zaRoot, artifactName +'-win32-x64.7z'); | |||
| let installerExe = path.join(zaRoot, artifactName + '-' + pjson.version + artifactType + '-installer.exe'); | |||
There was a problem hiding this comment.
Declaring installerExe here means that artifactType will always be empty, hence both simple and bundled installers will have the same name.
ppitonak
force-pushed
the
gulpfile-improvement
branch
from
b63b78e
to
8899d26
Compare
|
@jrichter1 fixed |
|
Released to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.