Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection never ends on macos #671

Merged

Conversation

dgolovin
Copy link
Contributor

Fix changes regex to accept version without _

Fix changes regex to accept version without _
@dgolovin
Copy link
Contributor Author

test this

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #671 into master will increase coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   95.98%   96.46%   +0.47%     
==========================================
  Files          29       29              
  Lines        2464     2599     +135     
  Branches      208      208              
==========================================
+ Hits         2365     2507     +142     
+ Misses         99       92       -7
Impacted Files Coverage Δ
browser/model/jdk-install.js 97.48% <100%> (+0.06%) ⬆️
browser/services/platform.js 90.37% <0%> (-0.05%) ⬇️
browser/pages/install/controller.js 100% <0%> (ø) ⬆️
browser/pages/start/controller.js 100% <0%> (ø) ⬆️
browser/services/request.js 100% <0%> (ø) ⬆️
browser/main.js 100% <0%> (ø) ⬆️
browser/model/helpers/installer.js 100% <0%> (ø) ⬆️
browser/model/installable-item.js 100% <0%> (ø) ⬆️
browser/model/helpers/hash.js 100% <0%> (ø) ⬆️
browser/model/devstudio.js 100% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199ef42...134ac75. Read the comment docs.

@dgolovin dgolovin merged commit fed0543 into redhat-developer-tooling:master Apr 21, 2017
@dgolovin dgolovin deleted the detection-never-ends-macos branch January 30, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants