JBDS-4423 Fuse Tools installer integrated #751
Conversation
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
=========================================
+ Coverage 97.92% 98.63% +0.7%
=========================================
Files 31 31
Lines 2848 3010 +162
Branches 244 436 +192
=========================================
+ Hits 2789 2969 +180
+ Misses 59 35 -24
- Partials 0 6 +6
Continue to review full report at Codecov.
|
browser/model/devstudio.js
Outdated
| @@ -9,14 +9,15 @@ import Logger from '../services/logger'; | |||
| import JdkInstall from './jdk-install'; | |||
|
|
|||
| class DevstudioInstall extends InstallableItem { | |||
| constructor(installerDataSvc, targetFolderName, downloadUrl, fileName, devstudioSha256, additionalLocations, additionalIus) { | |||
| super(DevstudioInstall.KEY, downloadUrl, fileName, targetFolderName, installerDataSvc, true); | |||
| constructor(keyName, installerDataSvc, targetFolderName, downloadUrl, fileName, sha256sum, additionalLocations, additionalIus, useDownload) { | |||
There was a problem hiding this comment.
Any particular reason to use keyName in constructor here, while other model classes use a combination of static Class.KEY and this.keyName?
There was a problem hiding this comment.
the reason is reusing it for fuse tools installation with additionalIus (IU - Installation Unit) configured in addition
|
I've run into a couple of problems while testing this:
|
|
Or rather it might be caused by the fact that devstudio filename gets updated in requirements.json during the build and fuse doesn't. |
|
Thanks Jan, I am looking into both issues. First is related to the fact that we have no generic dependency resolution. I've added 'requires' attribute to every components where applicable, but fact that CDK should work with ether virtualbox or hyper-v holding. Hope I'll find solution and resolve this issue till my PTO starts. Second seems to be simple bug to fix, because you already found the reason for it. |
dgolovin
changed the title
|
test this |
Fix add baseOrder calulation based on requirements.json instead of hardcoding it in componentLoader
This fix includes prep changes required for Fuse Tools Installer: * moves installer ordering configuration from code to requirements.json file; * introduce additional parameter for devstudio installer to allow fuse installer to provide correct key value; * introduces additional parameters to list additional IUs to install; * swithces to factory metod fromJason to create installer instances; * add 'requires' attributes to installer's configuration, but those are not used yet on confirmation page.
Fix add baseOrder calulation based on requirements.json instead of hardcoding it in componentLoader
No description provided.