Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite e2e tests to a sequence of pages #837

Merged
merged 1 commit into from
Aug 28, 2017

Conversation

jrichter1
Copy link
Collaborator

instead of one long test noodle, use a separate setup + test procedure for each page for easier maintenance and extending

@codecov-io
Copy link

codecov-io commented Aug 22, 2017

Codecov Report

Merging #837 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   96.49%   96.32%   -0.17%     
==========================================
  Files          35       35              
  Lines        3191     3375     +184     
  Branches      268      482     +214     
==========================================
+ Hits         3079     3251     +172     
- Misses        112      114       +2     
- Partials        0       10      +10
Impacted Files Coverage Δ
browser/model/devstudio.js 88.17% <0%> (-1.83%) ⬇️
browser/model/helpers/downloader.js 96.94% <0%> (-1.52%) ⬇️
browser/model/jbosseap.js 98.8% <0%> (-1.2%) ⬇️
browser/pages/about/controller.js 21.05% <0%> (-1.17%) ⬇️
browser/directives/componentPanel.js 14.28% <0%> (-1.1%) ⬇️
browser/pages/confirm/controller.js 89.71% <0%> (-0.93%) ⬇️
browser/services/data.js 97.03% <0%> (-0.92%) ⬇️
browser/model/jbossfuse.js 99.21% <0%> (-0.79%) ⬇️
browser/model/cdk.js 99.22% <0%> (-0.78%) ⬇️
browser/model/jdk-install.js 97.29% <0%> (-0.45%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4e4f3...c50672b. Read the comment docs.

@jrichter1 jrichter1 merged commit 176d003 into redhat-developer-tooling:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants