Fix #911 Add Eclipse Che Installer #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgolovin
commented
Oct 11, 2017
•
dgolovin
commented
|
test this |
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
==========================================
- Coverage 93.08% 93.05% -0.03%
==========================================
Files 42 43 +1
Lines 4467 4592 +125
Branches 493 781 +288
==========================================
+ Hits 4158 4273 +115
+ Misses 309 303 -6
- Partials 0 16 +16
Continue to review full report at Codecov.
|
coolbrg
reviewed
Oct 25, 2017
| progress.setStatus('Installing'); | ||
| let installer = new Installer(this.keyName, progress, success, failure); | ||
| return Promise.resolve().then(()=>{ | ||
| return installer.exec('minishift config set memory 5GB && minishift addon enable che', this.createEnvironment()); |
There was a problem hiding this comment.
@LalatenduMohanty looks like we are enabling during installation. I think we need to just set memory when user click to install Che. and point to documentation to apply che.
There was a problem hiding this comment.
@budhrg @LalatenduMohanty Why would we call it Eclipse Che Installer then?
dgolovin
changed the title
dgolovin
changed the title
dgolovin
changed the title
dgolovin
changed the title
LalatenduMohanty
approved these changes
Jan 12, 2018
| progress.setStatus('Installing'); | ||
| let installer = new Installer(this.keyName, progress, success, failure); | ||
| return Promise.resolve().then(()=>{ | ||
| return installer.exec('minishift config set memory 5GB && minishift addon enable che', this.createEnvironment()); |
coolbrg
approved these changes
Jan 12, 2018
|
Need rebase. |
|
Depends on #1213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.