This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Enhance Wildfly port detection #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thepetk
changed the title
thepetk
force-pushed
the
feature/add_wildfly_port_detection
branch
from
2152b2c
to
343abb6
Compare
mike-hoang
approved these changes
Jun 12, 2023
thepetk
changed the title
thepetk
changed the title
|
@mike-hoang let's first merge the #221 and then I'll rebase this one to main, move all common functionality to detectors and then push again :) This way I think we will avoid having duplicate code. |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
force-pushed
the
feature/add_wildfly_port_detection
branch
from
6a7d8ee
to
3fe0533
Compare
|
@mike-hoang I've made the rebase and I've made the code more dry for wildfly and JBoss thinking that we are using the same process for port detection. I've moved all common code into |
mike-hoang
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR follows the instructions of the related issue (#195) in order to add WildFly port detection from source code. Therefore upon
wildfly_detector.DoPortsDetection()it fetches the configuration file (pom.xml) and tries to find anyjavaOptsunder thewildfly-maven-plugin>profiles>plugin>configuration.If it finds one it tries to look for
jboss.https.portorjboss.http.portin order to see which is the port that is set up inside the file. Finally a test case is added for this enhancement withprojectWildflyas test resourceWhich issue(s) does this PR fix
Partially fixes #195
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer