Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate credentials for Java Kafka client #1783

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

rkpattnaik780
Copy link
Contributor

This PR adds an additional flag to rhoas service-account create and rhoas service-account reset-credentials for supporting properties file compatible with Java Kafka client.

Verification Steps

  1. Run the following command:
./rhoas service-account create --file-format java-kafka-properties --short-description java-properties
  1. It should create a file credentials.properties with credentials and callback URL.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I verified it, and it did create the credentials.properties correctly. I'm not sure if the content is 💯 accurate as I am not familiar with this part of the code.

JSONFormat = "json"
PropertiesFormat = "properties"
SecretFormat = "secret"
JavaPropertiesFormat = "java-kafka-properties"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just call it java-properties

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That did occur to me. But since .properties file are primarily used for java-related technologies, this name sounded redundant.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is java-kafka specific, so the name you've chosen seems reasonable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the verifying.

@rkpattnaik780 rkpattnaik780 merged commit dd956c2 into main Nov 15, 2022
@rkpattnaik780 rkpattnaik780 deleted the java_props branch November 15, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants