Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

adding git committer info to dockerfile to fix failing ci #21

Merged
merged 4 commits into from
Apr 18, 2019
Merged

adding git committer info to dockerfile to fix failing ci #21

merged 4 commits into from
Apr 18, 2019

Conversation

tinakurian
Copy link
Contributor

Fixing CI by adding git committer information.

@tinakurian tinakurian self-assigned this Apr 18, 2019
sbose78
sbose78 suggested changes Apr 18, 2019
View reviewed changes
Copy link
Member

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the same in Dockerfile.tools in openshift-ci/

@tinakurian
Copy link
Contributor Author

Please do the same in Dockerfile.tools in openshift-ci/

done here: 8722dce

@tinakurian tinakurian closed this Apr 18, 2019
@tinakurian tinakurian reopened this Apr 18, 2019
@tinakurian tinakurian requested a review from sbose78 April 18, 2019 14:16
@sbose78
Copy link
Member

sbose78 commented Apr 18, 2019

/test build

@openshift-ci-robot
Copy link
Collaborator

@tinakurian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/build 9b27160 link /test build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sbose78
sbose78 approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking in this change, because we need this anyway.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corinnekrych, sbose78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [corinnekrych,sbose78]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbose78
Copy link
Member

sbose78 commented Apr 18, 2019

need this to test openshift/release#3521

@sbose78 sbose78 merged commit 66060b5 into master Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbose78 sbose78 sbose78 approved these changes

@corinnekrych corinnekrych corinnekrych approved these changes

@baijum baijum Awaiting requested review from baijum

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov

Assignees

@tinakurian tinakurian

Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tinakurian @sbose78 @openshift-ci-robot @corinnekrych