This repository has been archived by the owner on Nov 10, 2021. It is now read-only.
Fixed registration tests and re-enabled download tests. #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulrobinson - even if we see export hold issues from time to time I think given the recent problems that have been missed by not testing downloads we should keep them enabled. We just need to be mindful that the kc_dm tests won't always pass and will need to check out the cucumber report when reviewing/merging. cc @LightGuard. |
ianrhamilton
changed the title
added 4 commits
January 16, 2017 12:06
…evious push did not run either.
…ues, and added hard coded users to test download flow on PR's.
ianrhamilton
changed the title
|
Is this good to go? |
|
@LightGuard yes please! Thanks! |
|
@paulrobinson this PR includes hardcoded users to test the download flow. 80% of download tests are still being ignored due to Export Hold issues. |
This was referenced Sep 15, 2021
This was referenced May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.