Skip to content
This repository has been archived by the owner on Nov 10, 2021. It is now read-only.

DEVELOPER-3817 - Add drop-down for language on RHEL #1748

Merged
merged 5 commits into from Feb 9, 2017

Conversation

KamiQuasi
Copy link
Contributor

https://issues.jboss.org/browse/DEVELOPER-3817

Adds the ability to use Angular attributes on div, a, and select tags to allow the changing of language values to hide/show content accordingly.

@@ -0,0 +1 @@
.wide.wide-hero.eclipse{background:url(/images/eclipse/eclipse_microsite_hero.jpg);background-size:cover;height:450px}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KamiQuasi Its worth checking with @LightGuard whether this should be committed. I believe most of the CSS in this directory is generated, so not sure if this should be here permanently.

cheers,

Rob

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robpblake I was wondering about that. It showed up after a build in my git status, but I thought it was generated because of the changes I made. @LightGuard do I just need to remove this and update the .gitignore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what generates this. I haven't looked into it either. I'd recommend removing it from the PR. If you'd like to take the extra time to figure out what's generating it, even better. First thoughts, it's something in the Gulp script.

Copy link
Member

@LightGuard LightGuard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra css file, if you can, stop it from being generated.

@@ -0,0 +1 @@
.wide.wide-hero.eclipse{background:url(/images/eclipse/eclipse_microsite_hero.jpg);background-size:cover;height:450px}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what generates this. I haven't looked into it either. I'd recommend removing it from the PR. If you'd like to take the extra time to figure out what's generating it, even better. First thoughts, it's something in the Gulp script.

@LightGuard LightGuard merged commit 10d70a3 into redhat-developer:master Feb 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants