Skip to content
This repository has been archived by the owner on Nov 10, 2021. It is now read-only.

Clean up rhdp.theme file #2708

Conversation

jordanpagewhite
Copy link
Contributor

This commit generally tidies up the rhdp.theme file. It applies Drupal
coding standards to almost the entire file, with a few exceptions for
line width. It applies a 2-space indentation to the entire file. It
reorganizes a few portions of the preprocessors to improve readability.

I have also discovered an issue in rhdp_preprocess_views_view() that
will throw an undefined variable error upon any execution of this hook.
I have noted that in the appropriate place in the file. We should
resolve that within the PR containing this commit if possible.

JIRA Issue Link

  • n/a

Verification Process

  • Nearly the entire .theme file should now conform to the Drupal coding standards
  • The functionality provided by these preprocessors, and any additional functions, within the .theme file should remain exactly the same

This commit generally tidies up the rhdp.theme file. It applies Drupal
coding standards to almost the entire file, with a few exceptions for
line width. It applies a 2-space indentation to the entire file. It
reorganizes a few portions of the preprocessors to improve readability.

I have also discovered an issue in rhdp_preprocess_views_view() that
will throw an undefined variable error upon any execution of this hook.
I have noted that in the appropriate place in the file. We should
resolve that within the PR containing this commit if possible.
@LightGuard LightGuard merged commit e633820 into redhat-developer:master Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants