Fix information about showed entries below paginated table. Closes #R… #297
Conversation
|
Can one of the admins verify this patch? |
|
Triggering build using a merge of 5459867 on branch master: |
|
Build 588 is now running using a merge of 5459867 on branch master: |
|
retest this please |
|
Not sure why this isn't being picked up. |
|
retest this please |
|
There was a build for this: http://developers-pr.stage.redhat.com/pr/297/build/588/. Not sure why the reporting on here was lost. |
|
@wesbos can you review? I agree with @lukas-vlcek's comment that it's probably better to move the calculations into the controller. Thoughts? |
|
👍 good to go from a code pov |
Fix information about showed entries below paginated table. Closes #R…
| // like: {{ Math.min(data.materials.length, paginate.currentPage * pagination.size) }} | ||
| // This might not be clean technique from Angular perspective (more clear would be | ||
| // to do all required calculations in controller and not the view) | ||
| $scope.Math = Math; |
There was a problem hiding this comment.
Goign to fix this - Math should not be passed into the scope
…HD-532.