-
Notifications
You must be signed in to change notification settings - Fork 125
[RHDX-248] Update Layout: 2 Column assembly type display #3495
[RHDX-248] Update Layout: 2 Column assembly type display #3495
Conversation
This changes the way that Layout: 2 Column assembly type will display content. We want to use this assembly type to support any kind of assembly-based, 2 column layouts, not just a left sidebar scenario. To do so, I have created 2 visual styles: Left sidebar and right sidebar. The default behavior, now, will be an evenly split 6:6 layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordanpagewhite this looks good!
My concern is I'm not sure how often the 6 X 6 columns will be used, but I understand the logic in have the default split down the middle.
This assembly can now be used to address the limitations @gdoyle1 came across with the right column eloqua field, correct? Or is that a separate ticket?
@sjcox-rh Yes, this will be used to address use cases like the Eloqua form issue that Gina experienced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot! Thanks @jordanpagewhite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good Jordan, the styles are exactly how I would have implemented them. Great job!
This changes the way that Layout: 2 Column assembly type will display
content. We want to use this assembly type to support any kind of
assembly-based, 2 column layouts, not just a left sidebar scenario. To
do so, I have created 2 visual styles: Left sidebar and right sidebar.
The default behavior, now, will be an evenly split 6:6 layout.
JIRA Issue Link
Relates to: https://projects.engineering.redhat.com/browse/RHDX-179
Verification Process
Default - no visual style
Right sidebar visual style
Left sidebar visual style
Important note
If/when merged, this will require a content update (update the visual style to Left Sidebar) of the 1 referenced Layout: Two Column assembly on Prod (the homepage). We could write a migration for that I suppose, but since there is only 1, it seems like a better use of time to just update the content manually.