This repository has been archived by the owner on Nov 10, 2021. It is now read-only.
[RHDX-248] Update Layout: 2 Column assembly type display #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way that Layout: 2 Column assembly type will display content. We want to use this assembly type to support any kind of assembly-based, 2 column layouts, not just a left sidebar scenario. To do so, I have created 2 visual styles: Left sidebar and right sidebar. The default behavior, now, will be an evenly split 6:6 layout.
jordanpagewhite
requested review from
alistairmc,
AdamJ,
sjcox-rh,
staceymosier,
gdoyle1 and
a user
sjcox-rh
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
@jordanpagewhite this looks good!
My concern is I'm not sure how often the 6 X 6 columns will be used, but I understand the logic in have the default split down the middle.
This assembly can now be used to address the limitations @gdoyle1 came across with the right column eloqua field, correct? Or is that a separate ticket?
|
@sjcox-rh Yes, this will be used to address use cases like the Eloqua form issue that Gina experienced |
alistairmc
approved these changes
Feb 7, 2020
This was referenced Jan 8, 2021
This was referenced May 5, 2021
This was referenced Jan 20, 2022
This was referenced Nov 15, 2022
This was referenced Nov 22, 2022
This was referenced Dec 20, 2023
This was referenced Jan 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way that Layout: 2 Column assembly type will display
content. We want to use this assembly type to support any kind of
assembly-based, 2 column layouts, not just a left sidebar scenario. To
do so, I have created 2 visual styles: Left sidebar and right sidebar.
The default behavior, now, will be an evenly split 6:6 layout.
JIRA Issue Link
Relates to: https://projects.engineering.redhat.com/browse/RHDX-179
Verification Process
Default - no visual style
Right sidebar visual style
Left sidebar visual style
Important note
If/when merged, this will require a content update (update the visual style to Left Sidebar) of the 1 referenced Layout: Two Column assembly on Prod (the homepage). We could write a migration for that I suppose, but since there is only 1, it seems like a better use of time to just update the content manually.