This repository has been archived by the owner on Nov 10, 2021. It is now read-only.
[RHDX-246] User login improvements for Status Message, Expandable content #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
self-assigned this
|
@rogeralloymagnetic can we use the inline style alerts pf-m-inline |
|
@alistairmc Sure, I've pushed an update. |
|
@rogeralloymagnetic looks like the e2e tests are broken on this |
|
Yeah, @alistairmc I was worried about that. I'll take a look. |
jordanpagewhite
changed the title
staceymosier
suggested changes
Feb 17, 2020
| <div {{ attributes.addClass(classes)|without('role', 'aria-label') }} aria-label="{{ status_headings[type] }}" role="contentinfo"> | ||
|
|
||
| <div class="pf-c-alert__icon"> | ||
| {% if type == 'custom' %} |
There was a problem hiding this comment.
Can these be set by line 32, to reduce checking again?
ghost
mentioned this pull request
|
Based off of wrong branch. Moved to: #3509 |
ghost
closed this
This was referenced Jan 8, 2021
This was referenced May 5, 2021
This was referenced Jan 20, 2022
This was referenced Nov 15, 2022
This was referenced Dec 20, 2023
This was referenced Jan 2, 2024
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Issue Link
Verification Process
Expandable
/user/loginunauthenticated.Status Message
/user/loginunauthenticated.layout-content .region-content #block-rhdp2-content form.user-login-formand deselect thedisplay: noneproperty.Screenshot