This repository has been archived by the owner on Nov 10, 2021. It is now read-only.
[RHDX-250] Adobe DDO Taxonomy #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides the functionality necessary to collect and pass the taxonomy terms referenced by a node/page to Adobe via the DDO digitalData object. These changes need to take place in both the rhdp and rhdp2 theme, since we are supporting both themes. Furthermore, this also updates the Adobe JS URLs and adds some footer JS per the Mojo doc: https://mojo.redhat.com/docs/DOC-1093367.
jordanpagewhite
requested review from
alistairmc,
robpblake,
staceymosier and
a user
jordanpagewhite
changed the title
|
rebuild this please |
Some Javascript in our html.html.twig files was overwriting digitalData.page.category to assign values to digitalData.page.category.primaryCategory and digitalData.page.category.subCategories. This is undesirable because we are passing values to the template, via rhd_dtm_script, from our PHP preprocessing.
This moves the taxonomy* key/values under digitalData.page.attributes instead of digitalData.page.category AND we are now using the taxonomy term ID, instead of the Term label, as value(s).
Updates on latest commit (8c6d5a5)In my latest commit, I've made 2 changes that Marcia requested:
|
BlockedOur review of this pull request seems blocked until a developers.redhat.com Adobe Analytics taxonomy data meeting on March 5 02:30-03:30pm EST. |
jordanpagewhite
changed the title
jordanpagewhite
changed the title
|
Per our call with Marcia last week, this PR is no longer blocked. We are exploring additional options/tasks (see: https://projects.engineering.redhat.com/browse/RHDX-250). |
|
rebuild this please |
staceymosier
suggested changes
Mar 10, 2020
There are instances where a Node object cannot be fetched, like User pages, our implementations of Product pages, etc. This adds some conditionals to ensure that we are handling these cases properly.
There were a few places where I would like to ensure that we have a non-empty object that is an instance of NodeInterface.
staceymosier
approved these changes
Mar 20, 2020
This was referenced Jan 8, 2021
This was referenced May 5, 2021
This was referenced Jan 20, 2022
This was referenced Nov 15, 2022
This was referenced Nov 22, 2022
This was referenced Dec 20, 2023
This was referenced Jan 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Issue Link
https://projects.engineering.redhat.com/browse/RHDX-250
Related Docs
https://mojo.redhat.com/docs/DOC-1093367
Verification Process
For each of the following scenarios/pages, do this:
digitalData.page.attributesor justdigitalDatainto the console to inspect the digitalData JS object. We are concern with key/values underdigitalData.page.attributesspecifically.You should see this:
digitalData.page.attributes.taxonomy*key/values should match the taxonomy terms referenced by the respective taxonomy field of that nodeOpenJDK (new, assembly-based Product page)
https://developer-preview-3515.ext.us-west.dc.preprod.paas.redhat.com/products/openjdk/overview
RHEL (old, paragraphs-based Product page)
https://developer-preview-3515.ext.us-west.dc.preprod.paas.redhat.com/products/rhel/overview
Kubernetes Topic Page
https://developer-preview-3515.ext.us-west.dc.preprod.paas.redhat.com/topics/kubernetes/
Containers Topic Page
https://developer-preview-3515.ext.us-west.dc.preprod.paas.redhat.com/topics/containers/