Reuse OLM installer. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
azatsarynnyy,
benoitf,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
56 tasks
|
che-incubator/chectl#724 merged. |
|
/cc @nickboldt |
nickboldt
reviewed
May 29, 2020
| @@ -89,7 +98,7 @@ platformString=" platform: string({\n\ | |||
| installerString=" installer: string({\n\ | |||
| char: 'a',\n\ | |||
| description: 'Installer type',\n\ | |||
| options: ['operator'],\n\ | |||
| options: ['operator', 'olm'],\n\ | |||
| default: 'operator'\n\ | |||
There was a problem hiding this comment.
should olm be the new default?
There was a problem hiding this comment.
for stable version of chectl olm is default installler for openshift 4.x f
nickboldt
reviewed
Jun 2, 2020
| -e "s|(const SUBSCRIPTION_NAME =).+|\1 'codeready-subscription'|g" \ | ||
| -e "s|(const OPERATOR_GROUP_NAME =).+|\1 'codeready-operator-group'|g" \ | ||
| -e "s|(const OPENSHIFT_OLM_CATALOG =).+|\1 'redhat-operators'|g" \ | ||
| -e "s|(CVS_PREFIX =).+|\1 'crwoperator'|g" \ |
There was a problem hiding this comment.
should this be CSV? looks like a typo in upstream :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reuse OLM installer.
What issues does this PR fix or reference?
eclipse-che/che#16862
Depends on:
che-incubator/chectl#724
How to test:
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com