Update sync script #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
tolusha
requested review from
benoitf,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
57 tasks
nickboldt
reviewed
Feb 12, 2021
| @@ -206,6 +206,11 @@ pushd "${TARGETDIR}" >/dev/null | |||
| mkdir -p "${TARGETDIR}/${d%/*}" | |||
| sed -r -e "s#DOC_LINK =.+#DOC_LINK = 'https://access.redhat.com/documentation/en-us/red_hat_codeready_workspaces/${CRW_VERSION}/'#" -i "${TARGETDIR}/${d}" | |||
| sed -r -e "s#DOC_LINK_RELEASE_NOTES.+#DOC_LINK_RELEASE_NOTES = 'https://access.redhat.com/documentation/en-us/red_hat_codeready_workspaces/${CRW_VERSION}/html/release_notes_and_known_issues/index'#" -i "${TARGETDIR}/${d}" | |||
|
|
|||
| # Restore replaced upstream project | |||
| sed -r -e "s#CHECTL_PROJECT_NAME =.+#CHECTL_PROJECT_NAME = 'chectl'#" -i "${TARGETDIR}/${d}" | |||
There was a problem hiding this comment.
why does downstream care about upstream chectl?
There was a problem hiding this comment.
Sync script completely replace chectl on crwctl but we have to check if current project is chectl or downstream one.
nickboldt
reviewed
Feb 12, 2021
| @@ -85,8 +85,7 @@ pushd "${SOURCEDIR}" >/dev/null | |||
| -e "/ const (minishiftAddonTasks|msAddonTasks) = new MinishiftAddonTasks\(\)/d" \ | |||
| -e '/.+tasks.add\(helmTasks.+/d' \ | |||
| -e '/.+tasks.add\((minishiftAddonTasks|msAddonTasks).+/d' \ | |||
| -e "s|(const DEFAULT_CHE_IMAGE =).+|\1 'registry.redhat.io/codeready-workspaces/server-rhel8:${CRW_SERVER_TAG}'|g" \ | |||
There was a problem hiding this comment.
DEFAULT_CHE_IMAGE is no longer a property?
DEFAULT_CHE_OPERATOR_IMAGE got renamed and the tag is removed?
asking 2nd question because relevant to CRW-1579 and CRW-1487, re: using :latest tags in crwctl
There was a problem hiding this comment.
We don't need this. That's kind of legacy.
The image must be defined in operator.yaml template.
Here is we just need a image name to check for update task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Update sync script
What issues does this PR fix or reference?
eclipse-che/che#18022
https://issues.redhat.com/browse/CRW-1589