Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit identityProvider patch and update quotas LimitRange exists #10

Merged
merged 2 commits into from Nov 17, 2022

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Nov 16, 2022

Signed-off-by: dkwon17 dakwon@redhat.com

The identityProvider patch was replacing the current identityProvider for some reason, this PR edits the patch to only add it instead.

PR also introduces an optional script that increases the user namespace's memory quotas for container and pods. This is because some clusters may have a default project template already set up with LimitRanges defined for new namespaces.

Signed-off-by: dkwon17 <dakwon@redhat.com>
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: dkwon17 <dakwon@redhat.com>
@dkwon17 dkwon17 merged commit 433bbaa into redhat-developer:main Nov 17, 2022
l0rd pushed a commit to l0rd/devspaces-demo that referenced this pull request Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants