Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: UI improvements #37

Merged
merged 2 commits into from
Mar 21, 2024
Merged

chore: UI improvements #37

merged 2 commits into from
Mar 21, 2024

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Mar 20, 2024

Reference issue

https://issues.redhat.com/browse/CRW-5953

What does this PR do

  • Add loaders during refreshing DevWorkspaces and connecting to the remote server
  • Refresh DevWorkspaces in the background
  • Don't block UI after connecting to the remote server
  • Don't allow to connect to the server is connection has been already established
  • Fixed bug when it was not possible to wait until remote project is ready
  • OpenShift API server connection params are loaded from kubeconfig and only then from plugin settings
  • Refactoring

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha marked this pull request as draft March 20, 2024 11:35
Copy link

github-actions bot commented Mar 20, 2024

Qodana Community for JVM

14 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 3
Unused import directive 🔶 Warning 2
Incorrect string capitalization 🔶 Warning 1
'equals()' and 'hashCode()' not paired 🔶 Warning 1
Redundant nullable return type 🔶 Warning 1
Might be 'const' ◽️ Notice 5
Redundant empty primary constructor ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

…shed

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha marked this pull request as ready for review March 21, 2024 11:13
@tolusha tolusha merged commit 433c4d0 into main Mar 21, 2024
6 checks passed
@tolusha tolusha deleted the CRW-5953 branch March 21, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants