Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pre-build DevWorkspace templates for devfile v2 #156

Closed
wants to merge 9 commits into from

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Dec 14, 2021

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Generate DW templates at build time and put them into /usr/local/apache2/htdocs/devfiles/v2/che-theia/ folder in the che-devfile-registry image.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-2500

Release Notes

Docs PR (if applicable)

@nickboldt
Copy link
Member

by the way some of this change might have to also be done in upstream repo https://github.com/redhat-developer/codeready-workspaces/tree/crw-2-rhel-8/dependencies/che-devfile-registry and then synched to this midstream repo using the sync.sh script.

@vinokurig vinokurig marked this pull request as ready for review December 20, 2021 16:54
@vinokurig vinokurig requested a review from svor December 20, 2021 16:54
@nickboldt nickboldt self-requested a review December 23, 2021 15:03
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickboldt
Copy link
Member

need updates to build/scripts/sync.sh script as noted in redhat-developer/codeready-workspaces#652 (comment)

Still need sync script to be updated. Airgap support == can't rely on surge.sh

@nickboldt
Copy link
Member

This PR is now outdated compared to https://github.com/redhat-developer/codeready-workspaces/pull/652/files and since that one should produce files which are synced from the crw to crw-images repo anyway, we likely don't need this PR.

Therefore closing.

@nickboldt nickboldt closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants