-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Pre-build DevWorkspace templates for devfile v2 #156
Conversation
codeready-workspaces-devfileregistry/build/scripts/clone_and_zip.sh
Outdated
Show resolved
Hide resolved
codeready-workspaces-devfileregistry/build/scripts/clone_and_zip.sh
Outdated
Show resolved
Hide resolved
codeready-workspaces-devfileregistry/build/scripts/generate_devworkspace_templates.sh
Outdated
Show resolved
Hide resolved
by the way some of this change might have to also be done in upstream repo https://github.com/redhat-developer/codeready-workspaces/tree/crw-2-rhel-8/dependencies/che-devfile-registry and then synched to this midstream repo using the sync.sh script. |
…workspaces-images into crw-2500
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need updates to build/scripts/sync.sh script as noted in redhat-developer/devspaces#652 (comment)
Still need sync script to be updated. Airgap support == can't rely on surge.sh |
This PR is now outdated compared to https://github.com/redhat-developer/codeready-workspaces/pull/652/files and since that one should produce files which are synced from the crw to crw-images repo anyway, we likely don't need this PR. Therefore closing. |
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
Generate DW templates at build time and put them into
/usr/local/apache2/htdocs/devfiles/v2/che-theia/
folder in the che-devfile-registry image.What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-2500
Release Notes
Docs PR (if applicable)