Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRW-3485 - remove IDEA from 3.3 Dashboard's... #343

Merged
merged 1 commit into from Nov 1, 2022
Merged

CRW-3485 - remove IDEA from 3.3 Dashboard's... #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions devspaces-dashboard/build/scripts/sync.sh
View file
Open in desktop
Expand Up @@ -181,5 +181,13 @@ while IFS= read -r -d '' d; do
fi
done < <(find ${TARGETDIR}/ -name "*.json" -type f -print0)

# https://issues.redhat.com/browse/CRW-3485 - disable IDEA from DS 3.3+ as we don't want to show tech preview editors in the dashboard
# TODO https://issues.redhat.com/browse/CRW-3489 - disable Theia from DS 3.4+ as it's deprecated / removed.
while IFS= read -r -d '' d; do
sed -r -e "s@EXCLUDED_TARGET_EDITOR_NAMES = .+@EXCLUDED_TARGET_EDITOR_NAMES = ['idea'];@" \
-i "${d}"
echo "Updated EXCLUDED_TARGET_EDITOR_NAMES in ${d}"
done < <(find ${TARGETDIR}/ -name "SamplesListGallery.tsx" -type f -print0)

# ensure shell scripts are executable
find ${TARGETDIR}/ -name "*.sh" -exec chmod +x {} \;
2 changes: 1 addition & 1 deletion ...ard/packages/dashboard-frontend/src/pages/GetStarted/GetStartedTab/SamplesListGallery.tsx
View file
Open in desktop
Expand Up @@ -64,7 +64,7 @@ type State = {

export const VISIBLE_TAGS = ['Community', 'Tech-Preview'];

const EXCLUDED_TARGET_EDITOR_NAMES = ['dirigible', 'jupyter', 'eclipseide', 'code-server'];
const EXCLUDED_TARGET_EDITOR_NAMES = ['idea'];

export class SamplesListGallery extends React.PureComponent<Props, State> {
private static sortByName(a: TargetEditor, b: TargetEditor): number {
Expand Down