Migrate ds-code container from ubi to rhel-els #587
Conversation
| # https://registry.access.redhat.com/ubi8/nodejs-18 | ||
| FROM ubi8/nodejs-18:1-110.1716503936 as checode-linux-libc-ubi8-builder | ||
| # https://registry.access.redhat.com/rhel9-6-els/rhel | ||
| FROM registry.redhat.io/rhel8-6-els/rhel:8.6 as checode-linux-libc-ubi8-builder |
There was a problem hiding this comment.
should we provide similar changes to https://github.com/redhat-developer/devspaces-images/blob/devspaces-3-rhel-8/devspaces-code/build/dockerfiles/Dockerfile ?
There was a problem hiding this comment.
Looking at the sync.sh script the base Dockerfile is no longer used as a template for the brew one, so it might not be needed at all.
It also looks like the sync script already ignores the build/dockerfiles directory so we don't have to worry about these changes getting overwritten.
There was a problem hiding this comment.
It will probably get updated automatically, but we should specify a build number, not just 8.6, for reproducibility etc
There was a problem hiding this comment.
- my comment was not about build on brew
- we had that Dockerfile for local build
- some time ago I found that it was broken, so I fixed it within feat: Support ubi9-based containers for running VS Code editor #547
It allows to build devspaces-code locally and it's helpful for investigation a problem(not related to brew) - as an investigation/debugging on brew is not easy process.
| @@ -457,15 +457,16 @@ USER root | |||
| COPY $REMOTE_SOURCES $REMOTE_SOURCES_DIR | |||
| WORKDIR $REMOTE_SOURCES_DIR/devspaces-images-code/app/devspaces-machineexec | |||
| # hadolint ignore=SC2086 | |||
| RUN CGO_ENABLED=0 GOOS=linux go build -mod=vendor -a -ldflags '-w -s' -a -installsuffix cgo -o che-machine-exec . && \ | |||
| RUN dnf -y install golang && \ | |||
| CGO_ENABLED=0 GOOS=linux go build -mod=vendor -a -ldflags '-w -s' -a -installsuffix cgo -o che-machine-exec . && \ | |||
| mkdir -p /rootfs/go/bin && cp -rf $REMOTE_SOURCES_DIR/devspaces-images-code/app/devspaces-machineexec/che-machine-exec /rootfs/go/bin | |||
|
|
|||
| ######################################################################### | |||
| ############################# BUILD 4: rootfs assembly ################## | |||
| ######################################################################### | |||
|
|
|||
| # https://registry.access.redhat.com/ubi8 | |||
There was a problem hiding this comment.
This comment should be updated as well, its how the updateBaseImages script knows what to look for.
|
This should definitely be tested in brew first to make sure there aren't any more gaps between the original source images and rhel-els |
|
In addition the https://github.com/redhat-developer/devspaces-images/blob/devspaces-3-rhel-8/devspaces-code/content_sets.yml file will need to be updated to use the els repos. So lines 255-257 will need to be updated as well |
https://issues.redhat.com/browse/CRW-6354
Migrates ds-code container from ubi to rhel-els