Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenShift templates #429

Merged
merged 7 commits into from
Feb 22, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 18, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Update OpenShift templates.

Regarding codeready labels.
We should be consistent with those created by operator. It uses cheFavor field from the CR to set labels.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHDEVDOCS-2483

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Feb 19, 2021

Regarding hardcoded 2.7 tag
I assume update_template.sh script should be a part of some sync procedure.
For now I run it manually to update templates.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@nickboldt
Copy link
Member

For now I run it manually to update templates.

What template file do you pass to the script? does it only have "nightly" as image tag version?

As to sync process, there is no such thing today as registries are forks from upstream. Introducing a new manual process is bad.

Instead, you could call your new script in one of two ways:

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Feb 22, 2021

I will update Jenkins file soon.

@tolusha
Copy link
Contributor Author

tolusha commented Feb 22, 2021

@nickboldt
I hope I addressed all your remarks.
Once PR is approved I will create a MR to update Jenkins file

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@nickboldt nickboldt merged commit 7f173e2 into redhat-developer:crw-2.7-rhel-8 Feb 22, 2021
nickboldt pushed a commit that referenced this pull request Feb 22, 2021
* Update OpenShift templates

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Fix image

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Fixes

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update templates and sync scripts

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Fixes

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Fixes

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Fix

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@nickboldt
Copy link
Member

Merged and cherrypicked.

See followup in #434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants