-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenShift templates #429
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
dependencies/che-devfile-registry/build/scripts/update_template.sh
Outdated
Show resolved
Hide resolved
dependencies/che-devfile-registry/build/scripts/update_template.sh
Outdated
Show resolved
Hide resolved
dependencies/che-devfile-registry/deploy/openshift/crw-devfile-registry.yaml
Outdated
Show resolved
Hide resolved
dependencies/che-devfile-registry/deploy/openshift/crw-devfile-registry.yaml
Outdated
Show resolved
Hide resolved
dependencies/che-plugin-registry/build/scripts/update_template.sh
Outdated
Show resolved
Hide resolved
dependencies/che-plugin-registry/deploy/openshift/crw-plugin-registry.yml
Outdated
Show resolved
Hide resolved
dependencies/che-plugin-registry/deploy/openshift/crw-plugin-registry.yml
Outdated
Show resolved
Hide resolved
Regarding hardcoded |
dependencies/che-devfile-registry/build/scripts/update_template.sh
Outdated
Show resolved
Hide resolved
dependencies/che-devfile-registry/build/scripts/update_template.sh
Outdated
Show resolved
Hide resolved
dependencies/che-devfile-registry/build/scripts/update_template.sh
Outdated
Show resolved
Hide resolved
dependencies/che-devfile-registry/build/scripts/update_template.sh
Outdated
Show resolved
Hide resolved
dependencies/che-plugin-registry/deploy/openshift/crw-plugin-registry.yml
Outdated
Show resolved
Hide resolved
What template file do you pass to the script? does it only have "nightly" as image tag version? As to sync process, there is no such thing today as registries are forks from upstream. Introducing a new manual process is bad. Instead, you could call your new script in one of two ways:
|
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
I will update Jenkins file soon. |
@nickboldt |
* Update OpenShift templates Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fix image Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fixes Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update templates and sync scripts Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fixes Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fixes Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fix Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Merged and cherrypicked. See followup in #434 |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Update OpenShift templates.
Regarding
codeready
labels.We should be consistent with those created by operator. It uses
cheFavor
field from the CR to set labels.What issues does this PR fix or reference?
https://issues.redhat.com/browse/RHDEVDOCS-2483