Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #19953 add tech-preview tag to meta.yaml #632

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Nov 26, 2021

What does this PR do?

chore: #19953 add tech-preview tags and rh-supported tags to the meta.yaml files; move python up from TP to GA tile order (05 -> 04)

(step 1 of eclipse-che/che#19953 )

Change-Id: Ib1d9a5bfd008e4793c052780276dea850d618f68
Signed-off-by: nickboldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19953

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt nickboldt changed the title chore: #19953 add tech-preview tags and... chore: #19953 add tech-preview tag to meta.yaml Nov 26, 2021
@nickboldt
Copy link
Member Author

See also eclipse-che/che-devfile-registry#523

@l0rd
Copy link
Contributor

l0rd commented Nov 29, 2021

Having one tag prefixed with rh- and not the other one is weird. I would rather have supported and tech-preview or rh-supported and rh-tech-preview.

….yaml files; move python up from TP to GA tile order (05 -> 04)

Change-Id: Ib1d9a5bfd008e4793c052780276dea850d618f68
Signed-off-by: nickboldt <nboldt@redhat.com>
Change-Id: I77730d1f0fbe7c9b924b4c82c385e9ac82262db4
Signed-off-by: nickboldt <nboldt@redhat.com>
@nickboldt
Copy link
Member Author

nickboldt commented Dec 1, 2021

Given Angel doesn't want the supported tag at all, and we don't plan to display them, I've removed 'em.

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants