Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvement: list of failed tests. #86

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

nicrowe00
Copy link
Contributor

@nicrowe00 nicrowe00 commented Feb 8, 2024

The test runner now returns a list of any tests that failed.

Closes #85.

@nicrowe00 nicrowe00 requested review from omajid and tmds February 8, 2024 11:18
@nicrowe00 nicrowe00 force-pushed the testrunner_ux branch 3 times, most recently from 6ccc1e3 to 2ec8fa9 Compare February 8, 2024 11:40
Turkey/TestRunner.cs Outdated Show resolved Hide resolved
@omajid
Copy link
Member

omajid commented Feb 8, 2024

The primary goal of the current UX is to show all test results alphabetically sorted, so the console output can easily diffed between runs.

I am fine with adding another UX format that optimized for a different use case. Maybe this new UX shows how many tests were run but otherwise focuses on failures? I don't know if mixing two different UX styles is a good idea, though.

Turkey/TestRunner.cs Outdated Show resolved Hide resolved
Turkey/TestOutputFormat.cs Outdated Show resolved Hide resolved
@tmds
Copy link
Member

tmds commented Feb 8, 2024

The primary goal of the current UX is to show all test results alphabetically sorted, so the console output can easily diffed between runs.

This PR doesn't change that much, does it?

Turkey/TestOutputFormat.cs Outdated Show resolved Hide resolved
Turkey/TestOutputFormat.cs Outdated Show resolved Hide resolved
The test runner now returns a list of any tests that failed.
Copy link
Member

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge this!

@nicrowe00 nicrowe00 merged commit cec2ad6 into redhat-developer:main Feb 21, 2024
19 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX by repeating list of failed tests at the end
3 participants