Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang to 1.19 #34

Merged
merged 2 commits into from
May 19, 2023

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented May 18, 2023

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
Bump golang to v1.19

Which issue(s) this PR fixes:

Fixes GITOPS-2923

How to test changes / Special notes to the reviewer:

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2023

Hi @svghadi. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@reginapizza
Copy link
Contributor

/ok-to-test

reginapizza
reginapizza previously approved these changes May 18, 2023
@jannfis
Copy link
Member

jannfis commented May 18, 2023

/ok-to-test

@wtam2018
Copy link
Collaborator

/lgtm
/approve

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@iam-veeramalla
Copy link

/lgtm
/approve

Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns, iam-veeramalla, wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chetan-rns,wtam2018]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f35d5b7 into redhat-developer:master May 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants